Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid abridged click output #2768

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Avoid abridged click output #2768

merged 2 commits into from
Aug 10, 2020

Conversation

ssbarnea
Copy link
Member

Fixes: #2733
Related: pallets/click#486

@ssbarnea ssbarnea added the bug label Jul 30, 2020
@ssbarnea ssbarnea added this to the 3.0.7 milestone Jul 30, 2020
ghost
ghost approved these changes Jul 30, 2020
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. To add some more context to this fix, the default width for Click is 80 characters which could truncate the help output.

@ssbarnea ssbarnea merged commit 1de5946 into ansible:master Aug 10, 2020
@ssbarnea ssbarnea deleted the fix/2733-short_help branch August 10, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-hellings greg-hellings greg-hellings approved these changes

@decentral1se decentral1se Awaiting requested review from decentral1se

@geerlingguy geerlingguy Awaiting requested review from geerlingguy

@sshnaidm sshnaidm Awaiting requested review from sshnaidm

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.0.7
Development

Successfully merging this pull request may close these issues.

Help output is truncated
2 participants
@ssbarnea @greg-hellings